Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2269: Setting a grace period when deleting resource using withPropagationPolicy() #2324

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Fix #2269: Setting a grace period when deleting resource using withPropagationPolicy() #2324

merged 1 commit into from
Jul 13, 2020

Conversation

rohanKanojia
Copy link
Member

Fix #2269

@rohanKanojia rohanKanojia requested a review from manusa July 3, 2020 11:54
devang-gaur
devang-gaur requested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@devang-gaur devang-gaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc change requested

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/GracePeriodConfigurable.java Outdated
* delete immediately.
*
* @param gracePeriodSeconds grace period integer value in seconds
* @return Deletable object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct this documentation line

@rohanKanojia
Copy link
Member Author

retest this please

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia merged commit b4873f4 into fabric8io:master Jul 13, 2020
@rohanKanojia rohanKanojia deleted the pr/issue2269 branch July 13, 2020 12:14
@Vlatombe Vlatombe mentioned this pull request Jul 16, 2020
Merged
11 tasks
Vlatombe added a commit to Vlatombe/kubernetes-client that referenced this pull request Jul 17, 2020
@Vlatombe
Update handler template taking into account fabric8io#2324
97bd165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devang-gaur devang-gaur devang-gaur requested changes

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting a grace period when deleting resource
4 participants
@rohanKanojia @manusa @oscerd @devang-gaur